Hi @ndrluis - thank you for turning the issue in #971 into these strategic items so quickly.

I'm +1 for re-enabling this flag as it will help us avoid issues like you've reported.

Testing this out in my dev environment, I see that other tests would also end up breaking with "expected" UserWarnings.

And example is:

UserWarning: Delete operation did not match any records, when overwrite is invoked in an empty table.

Some of our tests like: tests/catalog/test_sql.py::test_write_pyarrow_schema would fail in this case. One suggestion is to update this test to use table.append(pyarrow_table) instead so that these expected user warnings will not break our CI. WDYT?

Thank you for the review, @sungwy. I made the change in commit 1c6c409.

@ndrluis shall we rebase this branch with the fix you issued in the other PR #972 ?

ERROR tests/integration/test_writes/test_writes.py::test_rest_catalog_with_empty_catalog_name_append_data - UserWarning: Pydantic serializer warnings:
  Expected `TableIdentifier` but got `dict` - serialized value may not be as expected

@sungwy Done!

Thank you! Running the CI now

@ndrluis Ohh, this is nice. And sorry, it looks like I disabled this out a while ago 0cbb71c 🙈

Just to clarify the test changes:

  "ignore:A plugin raised an exception during an old-style hookwrapper teardown.",
  "ignore:unclosed <socket.socket",
  "ignore:distutils Version classes are deprecated. Use packaging.version instead.",

These are filtering third-party warnings.

I changed the table overwrite to append when it makes sense to avoid the "Delete operation did not match any records" error, and maintained the overwrite in an empty table or a delete operation where there is nothing to delete, as it makes sense.

Additionally, the "Merge on read is not yet supported, falling back to copy-on-write" is an expected warning in the test context.